-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand to a full range of parameters for TopicSpec #527
Comments
Currently creation of a topic spec is very limited, or you can create a topic with default def topic_partition_create(topic: str):
admin = FluvioAdmin.connect()
# create
paritions = 3
replication = 1
topic_spec = TopicSpec.new_computed(paritions, replication, False)
dry_run = False
admin.create_topic_spec(topic, dry_run, topic_spec) It would be nicer to expose at least all the parameters that def topic_partition_create(topic: str):
admin = FluvioAdmin.connect()
topic_spec = TopicSpec.new() # default spec
topic_spec.storage("1Gb")
topic_spec.retention_sec(3600)
topic_spec.segment_size("10M")
# ... etc
# make the create_topic(...) call a little more pythonic
admin.create_topic(topic) # creates with default spec
admin.create_topic(topic, topic_spec) # creates topic with more complex spec Reference
https://docs.rs/fluvio/latest/fluvio/metadata/topic/struct.TopicSpec.html |
https://infinyon.github.io/fluvio-client-python/fluvio.html#MetadataTopicSpec output by calls like https://infinyon.github.io/fluvio-client-python/fluvio.html#FluvioAdmin.all_topics should also expand. It would be nice to could also simplfy this so input and output TopicSpec are the same (but this isn't a hard requirement). -> Filed as Similar for https://infinyon.github.io/fluvio-client-python/fluvio.html#MetadataPartitionSpec returned by https://infinyon.github.io/fluvio-client-python/fluvio.html#FluvioAdmin.list_partitions. This could be broken off into smaller sub-issues or multiple PRs as needed. Filed issues: |
TopicSpec fixed w/ #528, allows creation of topics with a full range of parameters |
allow size specification et al from Python client
enhance create topic to allow optional spec
The text was updated successfully, but these errors were encountered: