Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated HostIP in telegraf-ds #608

Closed
caiocfer opened this issue Oct 24, 2023 · 1 comment
Closed

Duplicated HostIP in telegraf-ds #608

caiocfer opened this issue Oct 24, 2023 · 1 comment

Comments

@caiocfer
Copy link
Contributor

When deploying telegraf-ds, in the daemonset the HostIP is duplicated, they are both written in the values.yaml and daemonset.yaml

  - name: HOSTIP
    valueFrom:
      fieldRef:
        fieldPath: status.hostIP

from: https://github.com/influxdata/helm-charts/blob/master/charts/telegraf-ds/values.yaml#L39

        env:
        - name: HOSTIP
          valueFrom:
            fieldRef:
              fieldPath: status.hostIP
{{ toYaml .Values.env | indent 8 }}

from: https://github.com/influxdata/helm-charts/blob/master/charts/telegraf-ds/templates/daemonset.yaml#L43

When deployed the telegraf-ds' daemonset it's found:

        env:
        - name: HOSTIP
          valueFrom:
            fieldRef:
              fieldPath: status.hostIP
        - name: HOSTNAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
        - name: HOSTIP
          valueFrom:
            fieldRef:
              fieldPath: status.hostIP

I submitted a PR to fix this: #603

@powersj
Copy link
Contributor

powersj commented Oct 24, 2023

Fixed in #603

@powersj powersj closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants