Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(inputs.mysql) MariaDB example in dev/docker-compose.yml not fully functional #16159

Closed
grooverdan opened this issue Nov 7, 2024 · 2 comments · May be fixed by #16160
Closed

(inputs.mysql) MariaDB example in dev/docker-compose.yml not fully functional #16159

grooverdan opened this issue Nov 7, 2024 · 2 comments · May be fixed by #16160
Labels
feature request Requests for new plugin and for new features to existing plugins waiting for response waiting for response from contributor

Comments

@grooverdan
Copy link

Use Case

docker-compose up

Expected behavior

All inputs tested.

Actual behavior

Missing mariadb_dialect setting causes the non-MariaDB dialect to be used.

Additional info

No response
@grooverdan grooverdan added the feature request Requests for new plugin and for new features to existing plugins label Nov 7, 2024
grooverdan added a commit to grooverdan/telegraf that referenced this issue Nov 7, 2024
@grooverdan
fix(inputs.mysql): MariaDB example to include mariadb_dialect (influx…
f23099c 
…data#16159)

Also use MariaDB names and healthcheck to ensure running
before telegraf started.
@grooverdan grooverdan mentioned this issue Nov 7, 2024
Open
1 task
@srebhan
Copy link
Member

srebhan commented Nov 7, 2024

@grooverdan the files in dev were meant for doing (manual) integration tests. As we now do have real integration tests I would rather love to remove the dev directory altogether. What do you think?

Does this also affect the actual integration tests in mysql_test.go?

@srebhan srebhan added the waiting for response waiting for response from contributor label Nov 7, 2024
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins waiting for response waiting for response from contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(inputs.mysql): MariaDB example to include mariadb_dialect (#16159) grooverdan/telegraf
2 participants
@grooverdan @srebhan