Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong logic of ForceLoginDialog causes gtk client can't login for fresh session #9

Open
dmknght opened this issue Jan 31, 2021 · 0 comments

Comments

@dmknght
Copy link

dmknght commented Jan 31, 2021

  • Faraday GTK Client version: 0.1.0
  • Python version: 3.9
  • Operating System: Parrot OS 4.10

Description

In https://github.com/infobyte/faraday-client/blob/master/faraday_client/gui/gtk/application.py#L817, Faraday has check if user didn't login -> Force login using GTK dialog (related #5 ).
However, for totally new session, the config has no api_url in user.xml. Ofc everything works fine for current faraday_client version, but to make it be GUI login only (no terminal prompt) like #5, the dialog doesn't work at all

What I Did

  • Disable terminal login in start_client
  • Remove current session
  • Start faraday_client

I'm testing some code and i'll create pull request for working code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant