Add dynamic gas config to cosmos legacy bootstrap #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soareschen
reviewed
Nov 22, 2024
| @@ -31,7 +36,7 @@ fn test_celestia_bootstrap() -> Result<(), Error> { | |||
| cosmos_builder: builder.clone(), | |||
| chain_store_dir: store_dir.join("chains"), | |||
| bridge_store_dir: store_dir.join("bridges"), | |||
| dynamic_gas: Some(DynamicGasConfig::default()), | |||
There was a problem hiding this comment.
For CelestiaBootstrap, since this is chain-specific, we can probably make it either always have dynamic gas or not.
There was a problem hiding this comment.
Won't there be an issue with the CanUseLegacyCosmosSdkChainBootstrapper https://github.com/informalsystems/hermes-sdk/blob/main/crates/celestia/celestia-integration-tests/src/contexts/bootstrap.rs#L72?
|
|
||
| // TODO: Eventually use Config to define dynamic gas config | ||
| tx_config.gas_config.dynamic_gas_config = self.dynamic_gas.clone(); |
There was a problem hiding this comment.
Actually, we can modify build_chain_with_config to accept an additional parameter dynamic_gas_config.
The chain is being built here, and you can use Bootstrap: HasDynamicGasConfig to get the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Status
Waiting on informalsystems/cosmos.nix#280 and #476
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.