Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChainHandle dependency from build_create_client_payload #478

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Remove ChainHandle dependency from build_create_client_payload #478

merged 18 commits into from
Nov 29, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Nov 22, 2024

Closes: #XXX

Description

This PR adds the CanQueryStakingParams component

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 changed the title Add CanQueryStakingParams component Remove ChainHandle dependency from build_create_client_payload Nov 25, 2024
ljoss17 and others added 14 commits November 25, 2024 16:25
@ljoss17
Use CosmosCreateClientPayloadV2 in BuildCreateClientPayload
9141081
@ljoss17
Remove trusted light block verification from Cosmos build_create_clie…
8eb670e 
…nt_payload
@ljoss17
Use ibc-rs Height and ChainID instead of ibc-relayer-types in BuildCr…
22ac8b6 
…eateClientPayload
@ljoss17
Merge branch 'main' into luca_joss/add-query-stacking-params-component
671aab5
@ljoss17
Use CometLightClient to fetch light block in build_create_client_payload
672afeb
@ljoss17
Use ibc-relayer-types for CreateClientPayloadBuilder impl without Cha…
a59542b 
…inHandle
@ljoss17
Improve StakingParamsUnbondingPeriod and wire UnbondingPeriodQuerier …
e46f3f2 
…component
@soareschen
Wire up new payload builder
9799856
@ljoss17
Rename and cleanup BuildCosmosCreateClientPayload
f0cadc7
@ljoss17
Default trusting period to 2/3 of unbonding period if it is missing f…
8770505 
…rom client settings
@ljoss17
Use CosmosCreateClientOptions instead of ibc-relayer Settings
f30a44c
@ljoss17
Merge branch 'main' into luca_joss/add-query-stacking-params-component
e1413aa
@ljoss17
Use 14 days as default trusting_period in CosmosCreateClientOptions
42bde6a
@soareschen
Use default create client options in tests
b3b79de
@soareschen soareschen merged commit ec19ca0 into main Nov 29, 2024
10 checks passed
@soareschen soareschen deleted the luca_joss/add-query-stacking-params-component branch November 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoss17 @soareschen