Satisfy the golang compiler. #221
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Russell McConnachie <[email protected]> Signed-off-by: Russell McConnachie <[email protected]>
okanaganrusty
force-pushed
the
satisfy-dbobj-error-in-eventhook-tmpl
branch
from
ea0fdae to
9d0c2d4
Compare
iawells
reviewed
Apr 5, 2024
| @@ -163,6 +163,9 @@ | |||
| return nil, fmt.Errorf("failed to load object to get values for event, err %w", err) | |||
| } | |||
|
|
|||
| // Satisfies the go error: dbObj declared and not used | |||
There was a problem hiding this comment.
It does, but the better answer seems to be not to create dbObj if len($node.Fields) is 0, versus faking an access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This satisfies the errors generated by the event hook generators (line numbers may vary 🧷)