Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliders not working properly on Lunar Client #15

Open
GABRlEL opened this issue Nov 11, 2024 · 4 comments
Open

Sliders not working properly on Lunar Client #15

GABRlEL opened this issue Nov 11, 2024 · 4 comments

Comments

@GABRlEL
Copy link

GABRlEL commented Nov 11, 2024

Hey there, sorry to bother you with things that mix private work and business work.
I'm trying to make your mod work with Lunar Client for MCC Island 1.21 - and the sliders for the animationPresets don't work. They don't set any value and are draggable over the entire screen.
image
(please don't mind my ultrawide screen)

I tried to manually edit config but I can't get it to work, it won't load my config and just resets on game load. Editing scale works though, presumably because it's a text field and not a slider?

@GABRlEL
Copy link
Author

GABRlEL commented Nov 11, 2024

Please don't mind my hacky code, but changing the IntSlider to IntField does work, I have tried with my fork: https://github.com/GABRlEL/DulkirMod-Fabric-LunarSliderFix/blob/master/src/main/kotlin/com/dulkirfabric/config/DulkirConfig.kt
image

EDIT: I only fixed it for animations since this was the only thing relevant for me. I expect the fix to work everywhere though

@GABRlEL
Copy link
Author

GABRlEL commented Nov 14, 2024

short update, my fork (not sure if it's related to my fork or lunar) fails to load the config so you have to set the settings every time again

@inglettronald
Copy link
Owner

Sorry, I've been out of the house for the past few days, I'll try to look at this when I'm porting the mod to 1.21.3/4 soon(tm)!

@GABRlEL
Copy link
Author

GABRlEL commented Nov 15, 2024

Sorry, I've been out of the house for the past few days, I'll try to look at this when I'm porting the mod to 1.21.3/4 soon(tm)!

No worries! Atleast the MCC Island Modpack is not past 1.21 yet anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants