Skip building binaries in release.yml

ingonyama-zk · Nov 5, 2024 · 2909f0e · 2909f0e
1 parent 38712a9
commit 2909f0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -53,9 +53,10 @@ jobs:
       - name: Create draft release
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
+        run: |          
           mkdir -p release_output && rm -rf ./release_output/*
-          ./scripts/release/build_all.sh ./release_output
+          # skip building release tar. TODO Yuval fix
+          # ./scripts/release/build_all.sh ./release_output
           LATEST_TAG=$(git describe --tags --abbrev=0)
           gh release create $LATEST_TAG --generate-notes -d --verify-tag -t "Release $LATEST_TAG"
       - name: Upload release tars

diff --git a/scripts/release/build_all.sh b/scripts/release/build_all.sh
@@ -3,7 +3,7 @@
 set -e 
 
 # Use provided release_output directory or default to "release_output"
-output_dir="${1:-/release_output}"
+output_dir="${1:-./release_output}"
 
 # Check if both directories exist in the current working directory
 if [[ ! -d "./icicle" || ! -d "./scripts" ]]; then