updates for metal backend #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yshekel
commented
Nov 11, 2024
•
yshekel
commented
- add script to pull metal backend
- update cmake to build metal backend
- update rust wrappers with feature to build metal backend
- update examples to support any backend
- updated C++ test suites to share logic for selecting main device
yshekel
changed the title
yshekel
requested review from
jeremyfelder,
mickeyasa,
LeonHibnik,
Koren-Brand and
ShanieWinitz
mickeyasa
approved these changes
Nov 17, 2024
| @@ -37,7 +37,9 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON) | |||
| # Build options | |||
| option(BUILD_TESTS "Build unit tests. Default=OFF" OFF) | |||
| option(CPU_BACKEND "Build CPU backend. Default=ON" ON) | |||
| # TODO Yuval: consider decoupling backends from frontend build. Is that worth the effort? | |||
There was a problem hiding this comment.
is it?
Over time the cpu backend compilation time will be less efficient
There was a problem hiding this comment.
I referred to cuda and metal. I did not intend to split the CPU from this repo or build it separately.
We can discuss it but it's not related to this PR.
About metal and cuda, we could separate them entirely from the frontend cmake but it will complicate the backend. I am not sure if it is really worth it at this point although it is probably better to decouple the backends build entirely if we can.
scripts/pull_cuda_backend.sh
Outdated
|
|
||
| echo "Trying to pull CUDA backend commit '${CUDA_BACKEND}' to '${ABS_BACKEND_DIR}'" | ||
| echo "Trying to pull Metal backend commit '${CUDA_BACKEND}' to '${ABS_CUDA_DIR}'" |
There was a problem hiding this comment.
You probably meant CUDA here
yshekel
force-pushed
the
yshekel/metal_backend
branch
from
d7babce to
4947c00
Compare
jeremyfelder
approved these changes
Nov 24, 2024
yshekel
force-pushed
the
yshekel/metal_backend
branch
from
3661fef to
4d72054
Compare
yshekel
force-pushed
the
yshekel/metal_backend
branch
from
4d72054 to
b7c5c0c
Compare
yshekel
force-pushed
the
yshekel/metal_backend
branch
from
e7e0052 to
a0c3263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.