Replace random function to make CI reproducible #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a seed that will be set and printed in the start of test_curve_api. Additionally now ctest outputs console on failed runs. Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
yshekel
reviewed
Nov 25, 2024
icicle/include/icicle/fields/field.h
Outdated
| Field value{}; | ||
| for (unsigned i = 0; i < TLC; i++) | ||
| value.limbs_storage.limbs[i] = distribution(generator); | ||
| value.limbs_storage.limbs[i] = rand(); |
There was a problem hiding this comment.
maybe assert that limbs is 4 bytes here because rand() returns int. Otherwise if limbs is 64b then you don't randomize all numbers
There was a problem hiding this comment.
The implementation of limbs_storage in field is uint32 so it is an exact fit
There was a problem hiding this comment.
Apparently, rand has a maximal value of 2^15 - 1 so another solution might be better
yshekel
reviewed
Nov 25, 2024
yshekel
previously approved these changes
Nov 25, 2024
yshekel
changed the title
Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
yshekel
reviewed
Nov 26, 2024
yshekel
reviewed
Nov 26, 2024
icicle/include/icicle/fields/field.h
Outdated
| @@ -689,14 +689,18 @@ class Field | |||
| return rv; | |||
| } | |||
|
|
|||
| inline static std::mt19937 field_rand_generator = std::mt19937{}; | |||
There was a problem hiding this comment.
maybe better if you moved all of this to utils and use it here from utils.
There was a problem hiding this comment.
that's a good idea
Signed-off-by: Koren-Brand <[email protected]>
Signed-off-by: Koren-Brand <[email protected]>
yshekel
reviewed
Dec 1, 2024
icicle/include/icicle/fields/field.h
Outdated
| @@ -24,6 +24,7 @@ | |||
| #endif // __CUDACC__ | |||
|
|
|||
| #include "icicle/errors.h" | |||
| #include "icicle/utils/rand_gen.cpp" | |||
There was a problem hiding this comment.
you need to rename it to rand_gen.h
yshekel
reviewed
Dec 1, 2024
Koren-Brand
force-pushed
the
koren/change_random_and_ctest_for_easier_cli_debug
branch
from
c2cbfa2 to
49334a1
Compare
yshekel
approved these changes
Dec 2, 2024
Koren-Brand
changed the title
Koren-Brand
deleted the
koren/change_random_and_ctest_for_easier_cli_debug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR changes random generation to be based on rand such that bugs could be effectively reproduced.
Ctest (CI) Now outputs test log on test failure
Linked Issues
Resolves #