Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sumcheck API to Rust #770

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Expose sumcheck API to Rust #770

merged 7 commits into from
Feb 13, 2025

Conversation

jeremyfelder
Copy link
Collaborator

@jeremyfelder jeremyfelder commented Feb 11, 2025 •
edited
Loading

Describe the changes

This PR exposes the current Sumcheck API with a CPU backend via the Rust wrapper API

NOTE: Currently only exposed with predefined combine_functions and is not exposed in bw6 curve

cuda-backend-branch: feat/sumcheck/fix-typo

@jeremyfelder jeremyfelder force-pushed the feat/sumcheck/rust-api branch from 57e73e6 to 1efe01c Compare February 12, 2025 06:07
LeonHibnik
LeonHibnik reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@LeonHibnik LeonHibnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left a comment and discussed in private 💪

@jeremyfelder jeremyfelder force-pushed the feat/sumcheck/rust-api branch from 5f7d6be to b9c1dba Compare February 12, 2025 13:21
LeonHibnik
LeonHibnik approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@LeonHibnik LeonHibnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

yshekel
yshekel requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments.
You should be testing CUDA too. It's already merged to main branch. Please rerun ci against main cuda branch.

@jeremyfelder jeremyfelder requested a review from yshekel February 13, 2025 06:56
@jeremyfelder jeremyfelder merged commit 4d6fc11 into main Feb 13, 2025
15 checks passed
@jeremyfelder jeremyfelder deleted the feat/sumcheck/rust-api branch February 13, 2025 16:00
mickeyasa pushed a commit that referenced this pull request Feb 16, 2025
@jeremyfelder @mickeyasa
Expose sumcheck API to Rust (#770)
f962408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@mickeyasa mickeyasa Awaiting requested review from mickeyasa

@Koren-Brand Koren-Brand Awaiting requested review from Koren-Brand

@yshekel yshekel Awaiting requested review from yshekel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyfelder @yshekel @LeonHibnik