Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different branches #7

Open
wildi1 opened this issue Mar 1, 2024 · 5 comments
Open

Different branches #7

wildi1 opened this issue Mar 1, 2024 · 5 comments

Comments

@wildi1
Copy link

wildi1 commented Mar 1, 2024

Hello,
I would be interested why dob is not separated in different branches for various Odoo versions.
Thank you for the information.

@fkantelberg
Copy link
Member

There was no real reason to branch till now and nobody ever questioned it. I see a basic pro/cons situation:

If we branch we have to push the changes to multiple branches everytime. (e.g. update the CI, documentation of a new feature). dob can work down to Odoo version 8 (replace doblib with doblib-legacy in the dependencies if you want to go below 11.0).

If we keep everything in one branch you might have to adjust the odoo:version, maybe the python requirements and if you want to go pack further in the odoo versions the python version. These things we normally have to check for new projects anyways. The biggest pain is always the python packages and versions because we have to freeze and pin older packages for older versions. For a testing it's often enough to change only the odoo:version and the branches would have minimal changes.

Our current premise is:

  • This is a template repository
  • For demo purposes it's configured for the latest Odoo versions

@wildi1
Copy link
Author

wildi1 commented Mar 6, 2024

Ok, I understand your point. What about tagging the latest commit where dob was based on the previous Odoo version.
So when you need a specific odoo version you can simply checkout the tagged commit.

@fkantelberg
Copy link
Member

We have documented the features in the docs folder but the features are implemented within the python package dob-lib (version independent like debugger setup etc.). If we use tags the features are available but not documented. It would be worse than using branches for me because people would ask for documented features because they use old commits which only lack the documentation.

Maybe we can think about storing some patches within the repo to get to the different versions more easily. Not sure how we would handle the versions of the python packages.

@wildi1
Copy link
Author

wildi1 commented Mar 6, 2024

Ok thank you for your response. Anyway, it would be great if we could get a previous version of Odoo in a quick way. But doesn't matter. If you have got a suitable solution, feel free to make a short update here. Thank you for developing dob an making it Open Source.

@wildi1
Copy link
Author

wildi1 commented Mar 15, 2024

What is about placing different Dockerfiles in the repo:

  • Dockerfile (current Odoo version)
  • Dockerfile_v16
  • Dockerfild_v15
  • ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants