Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinstall hook fails #2

Open
geoffreylitt opened this issue Aug 27, 2020 · 2 comments
Open

postinstall hook fails #2

geoffreylitt opened this issue Aug 27, 2020 · 2 comments
Assignees

Comments

@geoffreylitt
Copy link
Collaborator

Running yarn install on a node project that depends on cambria results in this error:

error /Users/geoffreylitt/dev/arthropod2/arthropod/node_modules/cambria: Command failed.
Exit code: 127
Command: yarn run build
Arguments:
Directory: /Users/geoffreylitt/dev/arthropod2/arthropod/node_modules/cambria
Output:
yarn run v1.17.3
$ tsc --outDir ./dist

The problem is that we don't install dependencies before attempting to run yarn run build in the post-install hook.

Options:

  • replace yarn run build w/ a cross-platform-friendly version of yarn install && yarn run build (&& not windows-friendly)
  • put dist/ in git

I think this won't be a problem once we publish to npm -- I think we can publish dist to npm without putting it in source control.

@geoffreylitt geoffreylitt self-assigned this Aug 27, 2020
@geoffreylitt
Copy link
Collaborator Author

actually seems like && may be windows friendly, so I think I'm just going to use that.

https://stackoverflow.com/questions/39172536/running-npm-scripts-sequentially#comment89082222_39172660

@michielbdejong
Copy link

michielbdejong commented Jun 13, 2024

It looks like this issue was fixed that same day in f935be5 and can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants