Lint tests

Makefile

@@ -21,10 +21,10 @@ itest: check-venv
 precommit: format-check lint type-check utest
 
 lint: check-venv
-	@pylint inngest
+	@pylint inngest tests
 
 type-check: check-venv
-	@mypy inngest
+	@mypy inngest tests
 
 utest: check-venv
 	@pytest inngest

pyproject.toml

@@ -44,4 +44,5 @@ disable = [
     'missing-docstring',
     'too-few-public-methods',
     'too-many-arguments',
+    'unused-argument',
 ]

tests/base.py

@@ -7,7 +7,7 @@
 from .net import HOST
 
 
-class FrameworkTestCase(Protocol):
+class _FrameworkTestCase(Protocol):
     dev_server_port: int
     http_proxy: HTTPProxy
 
@@ -30,11 +30,11 @@ def register(app_port: int) -> None:
     assert res.status_code == 200
 
 
-def set_up(case: FrameworkTestCase) -> None:
+def set_up(case: _FrameworkTestCase) -> None:
     case.http_proxy = HTTPProxy(case.on_proxy_request).start()
 
 
-def tear_down(case: FrameworkTestCase) -> None:
+def tear_down(case: _FrameworkTestCase) -> None:
     case.http_proxy.stop()
 
 

tests/dev_server.py

@@ -9,14 +9,14 @@
 
 _enabled = os.getenv("DEV_SERVER_ENABLED") != "0"
 
-dev_server_port: int
+DEV_SERVER_PORT: int
 dev_server_port_env_var = os.getenv("DEV_SERVER_PORT")
 if dev_server_port_env_var:
-    dev_server_port = int(dev_server_port_env_var)
+    DEV_SERVER_PORT = int(dev_server_port_env_var)
 elif _enabled:
-    dev_server_port = get_available_port()
+    DEV_SERVER_PORT = get_available_port()
 else:
-    dev_server_port = _DEFAULT_DEV_SERVER_PORT
+    DEV_SERVER_PORT = _DEFAULT_DEV_SERVER_PORT
 
 
 class _DevServer:
@@ -31,15 +31,15 @@ def start(self) -> None:
             return
 
         def _run() -> None:
-            self._process = subprocess.Popen(
+            self._process = subprocess.Popen(  # pylint: disable=consider-using-with
                 [
                     "npx",
                     "inngest-cli@latest",
                     "dev",
                     "--no-discovery",
                     "--no-poll",
                     "--port",
-                    f"{dev_server_port}",
+                    f"{DEV_SERVER_PORT}",
                 ],
             )
             self._process.communicate()

tests/http_proxy.py

@@ -38,7 +38,7 @@ def _set_response(self, res: Response) -> None:
                 if res.body is not None:
                     self.wfile.write(res.body)
 
-            def do_DELETE(self) -> None:
+            def do_DELETE(self) -> None:  # pylint: disable=invalid-name
                 res = on_request(
                     body=self.rfile.read(int(self.headers["Content-Length"])),
                     headers=self._get_headers(),
@@ -56,7 +56,7 @@ def do_GET(self) -> None:
                 )
                 self._set_response(res)
 
-            def do_PATCH(self) -> None:
+            def do_PATCH(self) -> None:  # pylint: disable=invalid-name
                 res = on_request(
                     body=self.rfile.read(int(self.headers["Content-Length"])),
                     headers=self._get_headers(),
@@ -65,7 +65,7 @@ def do_PATCH(self) -> None:
                 )
                 self._set_response(res)
 
-            def do_POST(self) -> None:
+            def do_POST(self) -> None:  # pylint: disable=invalid-name
                 res = on_request(
                     body=self.rfile.read(int(self.headers["Content-Length"])),
                     headers=self._get_headers(),
@@ -74,7 +74,7 @@ def do_POST(self) -> None:
                 )
                 self._set_response(res)
 
-            def do_PUT(self) -> None:
+            def do_PUT(self) -> None:  # pylint: disable=invalid-name
                 res = on_request(
                     body=self.rfile.read(int(self.headers["Content-Length"])),
                     headers=self._get_headers(),

tests/test_flask.py

@@ -5,21 +5,21 @@
 
 import inngest
 
-from .base import FrameworkTestCase, register, set_up, tear_down
+from .base import register, set_up, tear_down
 from .cases import create_cases
-from .dev_server import dev_server_port
+from .dev_server import DEV_SERVER_PORT
 from .http_proxy import HTTPProxy, Response
 from .net import HOST
 
 _client = inngest.Inngest(
-    base_url=f"http://{HOST}:{dev_server_port}",
+    base_url=f"http://{HOST}:{DEV_SERVER_PORT}",
     id="flask",
 )
 
 _cases = create_cases(_client, "flask")
 
 
-class TestFlask(unittest.TestCase, FrameworkTestCase):
+class TestFlask(unittest.TestCase):
     app: FlaskClient
     dev_server_port: int
     http_proxy: HTTPProxy
@@ -63,7 +63,7 @@ def on_proxy_request(
 
         return Response(
             body=res.data,
-            headers={k: v for k, v in res.headers},
+            headers=dict(res.headers),
             status_code=res.status_code,
         )
 

tests/test_tornado.py

@@ -4,21 +4,21 @@
 
 import inngest
 
-from .base import FrameworkTestCase, register, set_up, tear_down
+from .base import register, set_up, tear_down
 from .cases import create_cases
-from .dev_server import dev_server_port
+from .dev_server import DEV_SERVER_PORT
 from .http_proxy import HTTPProxy, Response
 from .net import HOST
 
 _client = inngest.Inngest(
-    base_url=f"http://{HOST}:{dev_server_port}",
+    base_url=f"http://{HOST}:{DEV_SERVER_PORT}",
     id="tornado",
 )
 
 _cases = create_cases(_client, "tornado")
 
 
-class TestTornado(tornado.testing.AsyncHTTPTestCase, FrameworkTestCase):
+class TestTornado(tornado.testing.AsyncHTTPTestCase):
     app: Application
     dev_server_port: int
     http_proxy: HTTPProxy
@@ -63,7 +63,7 @@ def on_proxy_request(
 
         return Response(
             body=res.body,
-            headers={k: v for k, v in res.headers.items()},
+            headers=dict(res.headers.items()),
             status_code=res.code,
         )