try

inngest · Oct 22, 2023 · f956bcd · f956bcd
1 parent a70f11e
commit f956bcd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -38,4 +38,3 @@ jobs:
       #   run: "make utest"
       - name: "Integration test"
         run: "make itest"
-        # run: "npx --help"
diff --git a/tests/dev_server.py b/tests/dev_server.py
@@ -44,13 +44,9 @@ def _run() -> None:
             )
             self._process.communicate()
 
-        print(1)
         self._thread = threading.Thread(target=_run)
-        print(2)
         self._thread.start()
-        print(3)
         self._thread.join(timeout=10)
-        print(4)
 
     def stop(self) -> None:
         if not self._enabled:
@@ -64,13 +60,9 @@ def stop(self) -> None:
         if not self._thread.is_alive():
             raise Exception("thread is not alive")
 
-        print(5)
-        # self._process.terminate()
-        # self._process.send_signal(signal.SIGTERM)
+        # Would rather use `self._process.terminate()` but sometimes Dev Server
+        # takes too long to shutdown.
         os.kill(self._process.pid, signal.SIGKILL)
-        print(6)
-        # self._thread.join(timeout=10)
-        print(7)
 
 
 dev_server = _DevServer()