From f956bcd4f2981c0ba7badba971336edf2284089a Mon Sep 17 00:00:00 2001 From: Aaron Harper Date: Sun, 22 Oct 2023 10:44:36 -0400 Subject: [PATCH] try --- .github/workflows/ci.yml | 1 - tests/dev_server.py | 12 ++---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fa24c2bb..d28faab6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,4 +38,3 @@ jobs: # run: "make utest" - name: "Integration test" run: "make itest" - # run: "npx --help" diff --git a/tests/dev_server.py b/tests/dev_server.py index 1f656ebc..aaeac253 100644 --- a/tests/dev_server.py +++ b/tests/dev_server.py @@ -44,13 +44,9 @@ def _run() -> None: ) self._process.communicate() - print(1) self._thread = threading.Thread(target=_run) - print(2) self._thread.start() - print(3) self._thread.join(timeout=10) - print(4) def stop(self) -> None: if not self._enabled: @@ -64,13 +60,9 @@ def stop(self) -> None: if not self._thread.is_alive(): raise Exception("thread is not alive") - print(5) - # self._process.terminate() - # self._process.send_signal(signal.SIGTERM) + # Would rather use `self._process.terminate()` but sometimes Dev Server + # takes too long to shutdown. os.kill(self._process.pid, signal.SIGKILL) - print(6) - # self._thread.join(timeout=10) - print(7) dev_server = _DevServer()