Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storybook): add snapshot tests #698

Closed
wants to merge 8 commits into from
Closed

Conversation

janivo
Copy link
Collaborator

@janivo janivo commented Aug 15, 2022

Closes #713

  • add snapshot test for all stories

⚠️ currently blocked by storybookjs/test-runner#68 (comment)

@janivo janivo added the blocked This issue is blocked by another issue label Aug 15, 2022
@janivo
Copy link
Collaborator Author

janivo commented Aug 18, 2022

Seems to be fixed for now. Probably some weird dependency errors.

But there is still one problem: In some of our components we generate random IDs which lead to following errors:

    -       <label for="ino-switch-id__4h67rw409">
    +       <label for="ino-switch-id__8g9ktqkwt">

We need to think about how we want to handle these cases. IDs are necessary for <label> elements.

Proposals:

  • Mock the function that generates the ID's (preferred but might be hard, as only the dist of the core packages is available)
  • Add a 'hidden' property/data-attribute to pass an ID to the respective components

@janivo janivo mentioned this pull request Aug 25, 2022
@janivo janivo removed the blocked This issue is blocked by another issue label Aug 25, 2022
@janivo
Copy link
Collaborator Author

janivo commented Mar 16, 2023

closed for now because of flakiness

@janivo janivo closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snapshot tests
1 participant