Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R CMD CHECK note #12

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix R CMD CHECK note #12

merged 2 commits into from
Sep 18, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 28, 2024

* checking package dependencies ... NOTE
Vignette dependency required without any vignettes: ‘knitr’

Signed-off-by: Pawel Rucki <[email protected]>
@pawelru pawelru requested a review from a team as a code owner August 28, 2024 11:36
@pawelru
Copy link
Contributor Author

pawelru commented Aug 28, 2024

I have read the CLA Document and I hereby sign the CLA

@donyunardi donyunardi self-assigned this Sep 17, 2024
Copy link

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix this note by adding SECURITY.md to .Rbuildignore?

❯ checking top-level files ... NOTE
  Non-standard file/directory found at top level:
    ‘SECURITY.md’

Copy link
Contributor

github-actions bot commented Sep 18, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@pawelru
Copy link
Contributor Author

pawelru commented Sep 18, 2024

Thanks. Fixed this as well as the one about title case (turned on only for --as-cran)

@pawelru
Copy link
Contributor Author

pawelru commented Sep 18, 2024

I have read the CLA Document and I hereby sign the CLA

@pawelru pawelru enabled auto-merge (squash) September 18, 2024 09:46
@pawelru pawelru merged commit c82cd9f into main Sep 18, 2024
10 checks passed
@pawelru pawelru deleted the pawelru-patch-1 branch September 18, 2024 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants