Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tm_T_summary Module : Missing Search Bar in Drop-down List t #1128

Open
3 tasks done
Carlucc2 opened this issue Apr 22, 2024 · 3 comments
Open
3 tasks done

Tm_T_summary Module : Missing Search Bar in Drop-down List t #1128

Carlucc2 opened this issue Apr 22, 2024 · 3 comments
Labels
enhancement New feature or request sme

Comments

@Carlucc2
Copy link

Feature description

It seems there's been a change in the functionality of the search bar within the drop-down list in the tm_T_summary module. This feature was helpful for users to quickly find variables of interest by typing in their initials. However, it seems that this feature is no longer available, making it difficult for users to locate specific variables as they now have to scroll through a long list.
Now
image

Previous version
image

The search bar feature is still present in other modules like the Km plot.

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@Carlucc2 Carlucc2 added the enhancement New feature or request label Apr 22, 2024
@Carlucc2 Carlucc2 changed the title m_T_summary Module : Missing Search Bar in Drop-down List t Tm_T_summary Module : Missing Search Bar in Drop-down List t Apr 22, 2024
@donyunardi donyunardi added the sme label May 17, 2024
@Melkiades
Copy link
Contributor

Thanks for your question!! I think this is an intentional change related to the filter panel update. I am not sure but it seems that the select all deselect all took precedence to the filter. I am sure @gogonzo knows best though! :)

@gogonzo
Copy link
Contributor

gogonzo commented May 22, 2024

Thanks @Carlucc2 @Melkiades for letting us know about this.

@Carlucc2 it looks like this input has a livesearch when number of choices are more than 10. Can you confirm you are missing livesearch also when the number is >10?

library(teal.modules.clinical)
ADSL <- tmc_ex_adsl
ADSL$EOSDY[1] <- NA_integer_

app <- init(
  data = cdisc_data(
    ADSL = ADSL,
    code = "
      ADSL <- tmc_ex_adsl
      ADSL$EOSDY[1] <- NA_integer_
    "
  ),
  modules = modules(
    tm_t_summary(
      label = "Demographic Table",
      dataname = "ADSL",
      arm_var = choices_selected(choices = variable_choices(ADSL), selected = "ARM"),
      add_total = TRUE,
      summarize_vars = choices_selected(choices = variable_choices(ADSL), selected = "SEX"),
      useNA = "ifany"
    )
  )
)
shinyApp(app$ui, app$server)
Skärmavbild 2024-05-22 kl  09 44 48

@Carlucc2
Copy link
Author

Thanks @gogonzo and @Melkiades to follow-up on this. I confirm I'm not able to see the livesearch also when the number is >10. I included all variables from ADSL that is way more than 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sme
Projects
None yet
Development

No branches or pull requests

4 participants