Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup plot_with_settings namespaces names #743

Open
m7pr opened this issue Apr 24, 2024 · 0 comments
Open

Cleanup plot_with_settings namespaces names #743

m7pr opened this issue Apr 24, 2024 · 0 comments
Labels
core enhancement New feature or request

Comments

@m7pr
Copy link
Contributor

m7pr commented Apr 24, 2024

Feature description

If you grep for teal.widgets::plot_with_settings_ui you can see a discrepancy in naming convention for the plot namespaces.
In half of the examples we have meaningful names but in other half we have just myplot.

image

I suggest we unify, and either put the same name everywhere, or use custom meaningful names in all modules.
If we decide to stick with the same name all over the modules, I would suggest using plot instead of myplot.

Those names are used further in the name of the element of the page when shiny app is running, hence it's used in automated testing.

I suggest we also do that in other packages, below is the result for {teal.modules.clinical}.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant