-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADAL01 #116
Add ADAL01 #116
Conversation
Hi @qiliu1013, After your refactor of ADAB in I have commented out the broken parts of the code to create the listing for now, which generates ADAL01 without the four missing columns until this is fixed. |
Hi @edelarua, no need to show "Characterization Results" and "Patient Treatment Emergent NAb Status" in the ADAL01. A the new standard specs, there were move into PARAM now. We don't need to consider them. Did I answer all your questions? Thanks, |
To confirm - "Patient Treatment Emergent ADA Status" also no longer need to be considered, correct? If so then yes you answered all my questions, and the template should be ready for review! Thanks Qi!! |
Sorry. Patient Treatment Emergent ADA Status is PARAMCD = "ADASTAT1". No need to consider "Patient Treatment Emergent NAb Status" |
Unit Tests Summary340 tests 252 ✅ 59s ⏱️ Results for commit c34f282. ♻️ This comment has been updated with latest results. |
Hi @edelarua, can you please share the output with me? Thanks! |
hi @qiliu1013 , can you review the output at https://github.com/insightsengineering/tlg-catalog/pull/116/files#diff-800dcce08155543ad547403b286591745b8c15d6d35a7b4fec7dc33a51da067c please |
@qiliu1013 see a screenshot of the TLG-C output here: |
blocking this for the moment. It seems we need some refactoring in the rcd data again. |
@shajoezhu and @edelarua, can you please let me know where to find the latest adal01 code? I didn't see it under 37_adal01 branch. Thanks! |
I have read the CLA Document and I hereby sign the CLA 3 out of 4 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: Joe Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update snapshot
hi @edelarua , could you update the snapshot, once insightsengineering/random.cdisc.data#317 is in please. Thanks! |
this is potentially blocked by insightsengineering/random.cdisc.data#319 |
Snapshot has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @edelarua
Signed-off-by: Joe Zhu <[email protected]>
Signed-off-by: Joe Zhu <[email protected]>
Signed-off-by: Joe Zhu <[email protected]>
blocked by #270 |
Signed-off-by: Joe Zhu <[email protected]>
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit b4daf09 ♻️ This comment has been updated with latest results. |
Work from #38 moved here due to repo restructuring since previous PR was created.
Closes #37