-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RATET01
snapshot
#263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @edelarua
Unit Tests Summary340 tests 252 ✅ 59s ⏱️ Results for commit 5ad6e52. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 639e51f ♻️ This comment has been updated with latest results. |
Hi @shajoezhu, The integration tests for tlg-catalog test the stable version of the package but using the latest versions of the package dependencies so are not in sync with the stable version tested on GitHub via R CMD Check. Because of this, the current version of tlg-catalog is passing the checks on GitHub but not the integration tests, and if this PR is merged in integration tests will pass but the GitHub checks will fail. Is it possible to change the integration tests to match the GH checks so that both can pass? If not, we should probably leave the integration tests failing until the next release of rtables so the catalog does not break. |
This feels to me like an error in the test setup. Let's feedback this to IDR team and see what can be done. |
The mismatch has been fixed by changing integration tests to use the devel version, so tests should be passing now. |
Closes #262