Update safety table templates with modifications from chevron #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: @pawelru, without the snapshots-testing machinery it is very hard to review. Are there updates regarding that? :) |
|
So it's currently blocked by CI updates. Let me explore if this is real blocker and whether we can merge as is and update CI later on. |
On a separate note, these are all significant changes in the logic and as of now tests should fail on snapshots comparison (currently there are no updates to the snapshots). @vedhav can you please have a look why it's passing? |
Melkiades
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
See insightsengineering/scda.test@c4990ad for corresponding snapshot updates of these templates.