From d609178c3ae278ba377efa2bbdaf10e4f4d71b6a Mon Sep 17 00:00:00 2001 From: Jens Balvig Date: Wed, 7 Aug 2019 11:36:39 +0200 Subject: [PATCH] don't treat Kafka connection errors as database errors --- .../connection_adapters/makara_abstract_adapter.rb | 1 - .../makara_abstract_adapter_error_handling_spec.rb | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/active_record/connection_adapters/makara_abstract_adapter.rb b/lib/active_record/connection_adapters/makara_abstract_adapter.rb index ba1bfea1..d3881824 100644 --- a/lib/active_record/connection_adapters/makara_abstract_adapter.rb +++ b/lib/active_record/connection_adapters/makara_abstract_adapter.rb @@ -20,7 +20,6 @@ class ErrorHandler < ::Makara::ErrorHandler /(closed|lost|no|terminating|terminated)\s?([^\s]+)?\sconnection/, /gone away/, /connection[^:]+refused/, - /could not connect/, /can\'t connect/, /cannot connect/, /connection[^:]+closed/, diff --git a/spec/active_record/connection_adapters/makara_abstract_adapter_error_handling_spec.rb b/spec/active_record/connection_adapters/makara_abstract_adapter_error_handling_spec.rb index 200d1f5e..773bc89a 100644 --- a/spec/active_record/connection_adapters/makara_abstract_adapter_error_handling_spec.rb +++ b/spec/active_record/connection_adapters/makara_abstract_adapter_error_handling_spec.rb @@ -59,6 +59,14 @@ end end + it "shouldn't treat Kafka connection errors as database errors" do + expect { + handler.handle(connection) do + raise "Could not connect to any of the seed brokers" + end + }.to raise_error(RuntimeError) + end + describe 'custom errors' do let(:config_path) { File.join(File.expand_path('../../../', __FILE__), 'support', 'mysql2_database_with_custom_errors.yml') }