Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Clang for more reliable sysroot-handling #4

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

ltrk2
Copy link

@ltrk2 ltrk2 commented Dec 3, 2024

No description provided.

@ltrk2 ltrk2 requested a review from a team December 3, 2024 20:02
Copy link

sonarcloud bot commented Dec 3, 2024

@bhavnajindal
Copy link

I assume this change is only for our internal fork. In that case we would diverge from the OSS. Do we need to export this change to OSS? If not, what would be the long term impact?

@ltrk2
Copy link
Author

ltrk2 commented Dec 4, 2024

I think we'll end up diverging in the aspect of build configuration for the time being, because we need support for cross-compiling based on sysroots best supported by Clang, while the original project uses standalone GCC cross-compilers (more on the topic here).

@ltrk2
Copy link
Author

ltrk2 commented Dec 4, 2024

Once we get this right we could definitely look at contributing it to the community along with sysroots that determine a compatibility baseline. However, this will likely spur non-trivial discussions.

@ltrk2 ltrk2 merged commit e7acabc into main Dec 4, 2024
3 checks passed
@ltrk2 ltrk2 deleted the feature/use-clang branch December 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants