Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test runner to CI #12

Closed
nathan-weinberg opened this issue Jun 24, 2024 · 6 comments · Fixed by #155
Closed

Add test runner to CI #12

nathan-weinberg opened this issue Jun 24, 2024 · 6 comments · Fixed by #155
Assignees
Labels
CI/CD Affects CI/CD configuration

Comments

@nathan-weinberg
Copy link
Member

@danmcp has introduced some tests in #9 - we should get testing setup as part of our current CI stack once they are merged in

@nathan-weinberg nathan-weinberg added the enhancement New feature or request label Jun 24, 2024
@nathan-weinberg nathan-weinberg self-assigned this Jun 24, 2024
@nathan-weinberg nathan-weinberg added CI/CD Affects CI/CD configuration and removed enhancement New feature or request labels Jun 24, 2024
@nathan-weinberg
Copy link
Member Author

Note for this we will need a GPU-enabled runner with the following specs:

  • 24GB vram for MT-Bench
  • 96GB vram for MMLU

@russellb
Copy link
Member

russellb commented Jul 2, 2024

Note for this we will need a GPU-enabled runner with the following specs:

  • 24GB vram for MT-Bench

This job should be capable:

instructlab/instructlab#1556

I can help get the same thing running on this repo, but it will take some additional repo configuration first.

  • 96GB vram for MMLU

do you have an AWS instance type in mind? Ideally the minimal / cheapest type capable of testing this

@danmcp
Copy link
Member

danmcp commented Jul 2, 2024

For the simple flow test, 24GB of vram should work for both. I haven't tried to make it work with less. We've been using g5.4xlarge.

@alimaredia
Copy link
Contributor

I think we can make CI work with a g4dn.2xlarge instance. I'm going to give it a try today and report back on this issue. If not the g5.4xlarge should definitely work.

@booxter
Copy link
Contributor

booxter commented Jul 30, 2024

@alimaredia any updates on this issue? It would be nice to validate patches in the repo through CI before merging.

@alimaredia
Copy link
Contributor

@booxter I don't have any updates. I've been focused on the instructlab CI lately. If someone wants to take the lead on establishing CI within the eval repo over the next week or so I'd be happy to review or tell that person what I see the next steps are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration
Projects
None yet
5 participants