Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let go of legacy simple SDG self instruct leaf node keys #102

Closed
oindrillac opened this issue Jul 8, 2024 · 3 comments
Closed

Let go of legacy simple SDG self instruct leaf node keys #102

oindrillac opened this issue Jul 8, 2024 · 3 comments
Labels
refactor Same results, different method stale

Comments

@oindrillac
Copy link
Contributor

With SDG simple following the pipeline approach instead of legacy self instruct loop, we do not need to convert keys to required format for self instruct here

"instruction": question,
"input": context,
"output": answer,
"taxonomy_path": tax_path,
"task_description": task_description,
"document": documents,
"domain": domain,
and convert them back here
def _skill_leaf_node_to_samples(leaf_node):
samples = []
# pylint: disable=consider-using-enumerate
for i in range(len(leaf_node)):
samples.append({})
samples[-1]["task_description"] = leaf_node[i]["task_description"]
if leaf_node[i].get("input"):
samples[-1]["seed_context"] = leaf_node[i]["input"]
samples[-1]["seed_question"] = leaf_node[i]["instruction"]
samples[-1]["seed_response"] = leaf_node[i]["output"]
return samples

we can simply use the keys consistent with the latest structure

@russellb
Copy link
Member

russellb commented Jul 8, 2024

related to #59

@nathan-weinberg nathan-weinberg added the refactor Same results, different method label Aug 20, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 22, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Same results, different method stale
Projects
None yet
Development

No branches or pull requests

3 participants