Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server_ctx_size is ignored in document chunking method #69

Closed
russellb opened this issue Jul 2, 2024 · 2 comments
Closed

server_ctx_size is ignored in document chunking method #69

russellb opened this issue Jul 2, 2024 · 2 comments
Labels
bug Something isn't working stale

Comments

@russellb
Copy link
Member

russellb commented Jul 2, 2024

Our code passes in the server context size passed in from the CLI to the document chunking method, but then it's just ignored. We should do something with it presumably!

I noticed this when reviewing #65
@nathan-weinberg nathan-weinberg added the bug Something isn't working label Aug 20, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 23, 2024
@bbrowning
Copy link
Contributor

We fixed this some months back but didn't mark this issue as closed. We now use the configured server_ctx_size when determining how to split up the chunks.

jwm4 pushed a commit to jwm4/sdg that referenced this issue Dec 13, 2024
@russellb
Merge pull request instructlab#69 from russellb/backend
2ce89f1 
Propose a backend working group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbrowning @russellb @nathan-weinberg