You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, it's a bad practice for a consuming library to depend on these values as it is a circular dependency.
SDG should either parameterize these values or have its own concept for DEFAULT_API_KEY and DEFAULT_MODEL_OLD
so as to decouple itself from the instructlab CLI in this direction.
The text was updated successfully, but these errors were encountered:
This repository currently has dependencies on values from
instructlab.configuration
, which is consuming SDG.Specifically, the
utils.py
is importing values from configuration that will no longer existwith this PR in instructlab: instructlab #1471.
In general, it's a bad practice for a consuming library to depend on these values as it is a circular dependency.
SDG should either parameterize these values or have its own concept for
DEFAULT_API_KEY
andDEFAULT_MODEL_OLD
so as to decouple itself from the instructlab CLI in this direction.
The text was updated successfully, but these errors were encountered: