Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on instructlab/instructlab #88

Closed
RobotSail opened this issue Jul 5, 2024 · 3 comments
Closed

Remove dependencies on instructlab/instructlab #88

RobotSail opened this issue Jul 5, 2024 · 3 comments

Comments

@RobotSail
Copy link
Member

This repository currently has dependencies on values from instructlab.configuration, which is consuming SDG.

Specifically, the utils.py is importing values from configuration that will no longer exist
with this PR in instructlab: instructlab #1471.

In general, it's a bad practice for a consuming library to depend on these values as it is a circular dependency.

SDG should either parameterize these values or have its own concept for DEFAULT_API_KEY and DEFAULT_MODEL_OLD
so as to decouple itself from the instructlab CLI in this direction.

@RobotSail
Copy link
Member Author

Closing this as it seems to have already been resolved.

@russellb
Copy link
Member

russellb commented Jul 6, 2024

Yeah, this was just true during transition because the code that started the repo was extracted from the instructlab repo

@russellb
Copy link
Member

russellb commented Jul 6, 2024

#11 tracked the steps remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants