From 7b11fab30c084e7f96147feee98ac00423cfbf08 Mon Sep 17 00:00:00 2001 From: Suhaib Al-Absi Date: Sun, 22 Dec 2024 16:25:06 +0300 Subject: [PATCH] Fix E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen refs: MBL-18084 affects: Student release note: Fixes E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen --- Core/Core/Grades/View/GradeListView.swift | 1 + Student/StudentE2ETests/Grades/GradingPeriodsTests.swift | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/Core/Core/Grades/View/GradeListView.swift b/Core/Core/Grades/View/GradeListView.swift index f45438e243..ff9d2d56db 100644 --- a/Core/Core/Grades/View/GradeListView.swift +++ b/Core/Core/Grades/View/GradeListView.swift @@ -112,6 +112,7 @@ public struct GradeListView: View, ScreenViewTrackable { : .textLightest) } + .hidden(viewModel.state == .initialLoading) .accessibilityLabel(Text("Filter", bundle: .core)) .accessibilityHint(Text("Filter grades options", bundle: .core)) .accessibilityIdentifier("GradeList.filterButton") diff --git a/Student/StudentE2ETests/Grades/GradingPeriodsTests.swift b/Student/StudentE2ETests/Grades/GradingPeriodsTests.swift index add83048f5..62f4b0569b 100644 --- a/Student/StudentE2ETests/Grades/GradingPeriodsTests.swift +++ b/Student/StudentE2ETests/Grades/GradingPeriodsTests.swift @@ -22,7 +22,6 @@ class GradingPeriodsTests: E2ETestCase { typealias Helper = GradesHelper func testGradingPeriodsFilter() throws { - try XCTSkipIf(true, "Skipped because of MBL-18023.") // MARK: Seed the usual stuff with grading periods containing graded assignments let student = seeder.createUser() let enrollmentTerm = Helper.createEnrollmentTerm()