Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadMe outdated - JWT secrets moved to vault #62

Open
joehobson opened this issue Jun 9, 2023 · 3 comments
Open

ReadMe outdated - JWT secrets moved to vault #62

joehobson opened this issue Jun 9, 2023 · 3 comments

Comments

@joehobson
Copy link

A recent commit in Canvas LMS moved the location of the encryption-secret and signing-secret config values from dynamic_settings.yml to vault_contents.yml (in Canvas LMS). The README.md for this repo needs to be updated, but should specify at which release Canvas changed to accommodate users deploying older releases.

Appreciation goes out to Graham Ballantyne for bringing this to our attention on the Canvas LMS users group: https://groups.google.com/u/7/g/canvas-lms-users/c/ydvfmtw2CLE

@linnil1
Copy link

linnil1 commented Jun 10, 2023

Same issue here.
I found that there exists a document somewhere in canvas-lms repo.
And it works.
https://github.com/instructure/canvas-lms/blob/master/packages/canvas-rce/DEVELOPMENT.md#canvas-rce-api

@fchienvuhoang
Copy link

vote this!!!!

@adeel-raza
Copy link

+1
The readme should be updated. This is so messed up that a breaking change 3 months ago has not been reflected in the doc. It's not even updated after the issue has been raised on the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants