Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization of suite parameters overrides empty values on forks #167

Closed
olley opened this issue Jan 4, 2018 · 1 comment
Closed
Labels
Milestone

Comments

@olley
Copy link

olley commented Jan 4, 2018

Consider the following test suite:

forkdef myFork
suitedef forkTest with
	suite otherSuite on myFork
	suite otherSuite aParam: "test"
	suite otherSuite on myFork // aParameter is still "test"
suiteend
suitedef otherSuite gets aParam with
	test fixtures.returnObject object: aParam = "test"
suiteend

Since the third call of "otherSuite" on "myFork" includes no parameter, it should be treated as "null" (with test results expected to be "failure, success, failure"), however instead the value "test" from the previous invocation is injected.

@S1artie S1artie added the bug label Jan 4, 2018
@S1artie S1artie closed this as completed in fb9b60e Jan 4, 2018
@S1artie S1artie added this to the v0.17.4 milestone Jan 4, 2018
@S1artie
Copy link
Member

S1artie commented Jan 4, 2018

There was actually quite a bit of inconsistency in the way suite parameters were cleared after leaving the respective suites between forks and the master, which created this problem here. I have now attempted to synchronize this behavior, so forks and master should have an identical view on variable values (and suite params are just suite-scoped variables in the end).

It would come as little surprise if this would even fix this strange non-reproducable issue #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants