Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose timeout for streamer for fastchat worker #11288

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Expose timeout for streamer for fastchat worker #11288

merged 2 commits into from
Jun 12, 2024

Conversation

Oscilloscope98
Copy link
Contributor

@Oscilloscope98 Oscilloscope98 commented Jun 12, 2024 •
edited
Loading

Description

Expose timeout for streamer for fastchat worker; through env variable FASTCHAT_WORKER_API_TIMEOUT

Reference: https://github.com/lm-sys/FastChat/blob/74aa8ae36659092542a24bf03df1c35ce94ba494/fastchat/constants.py#L45

gc-fu
gc-fu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@gc-fu gc-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oscilloscope98 Oscilloscope98 force-pushed the expose-timeout-for-fastchat-worker branch from dd4c5cc to 8f9226a Compare June 12, 2024 08:54
@Oscilloscope98 Oscilloscope98 merged commit cffb932 into intel:main Jun 12, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gc-fu gc-fu gc-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oscilloscope98 @gc-fu