Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended building and runtime dependences for MKL. #1325

Open
fengyuan14 opened this issue Jan 24, 2025 · 2 comments
Open

Recommended building and runtime dependences for MKL. #1325

fengyuan14 opened this issue Jan 24, 2025 · 2 comments
Assignees
Milestone

Comments

@fengyuan14
Copy link
Contributor

🚀 The feature, motivation and pitch

So far, #526 implemented the first MKL related operator, aten.fft_c2c. The PR introduced MKL building system in torch-xpu-ops. The MKL SDK introduced for building bases on oneAPI package.

The potential issue is we would recommend using pip install mkl-dpcpp for runtime. There would be potential API breaking issue when MKL version in oneAPI package for building has gap with MKL in Pypi.

We need to unify recommended MKL package for building and runtime.

Alternatives

No response

Additional context

No response

@gajanan-choudhary
Copy link

Is there a plan to add other oneMKL APIs such as those from Sparse BLAS in torch-xpu-ops? I'm seeing things like #1330 which appear to start adding Sparse CSR support but aren't (or maybe can't yet be?) using oneMKL.

@CuiYifeng
Copy link
Contributor

@gajanan-choudhary Thanks for your question!
Some sparse ops, such as _sparse_sparse_matmul and _sparse_addmm, will be implemented with oneMKL.
Since ops in #1330 are implemented without MKL in Pytorch CPU, this choice has been retained. For now, functionality first, so relying less is better. These ops may be refined using oneMKL in future.

@CuiYifeng CuiYifeng added this to the 2.8 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants