Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of LWP #1

Open
racke opened this issue Jul 11, 2014 · 1 comment
Open

Get rid of LWP #1

racke opened this issue Jul 11, 2014 · 1 comment
Assignees

Comments

@racke
Copy link
Member

racke commented Jul 11, 2014

Let's use something modern, like HTTP::Tiny. See http://www.martin-evans.me.uk/node/169.

@melmothx
Copy link
Contributor

Inside the HI code, LWP is used only by TeamWork, and needs to use basic authentication. Now, we could manipulate the headers and pass them, but here for the sake of performances we risk to introduce bugs and malfunctioning and ugly code.

Even if we start using HTTP::Tiny in TW, the other module will still use LWP, so the performance gain is minimal at best. Unless we want to patch other modules as well, but see above.

Given that almost all the used modules interface with external services (which are hard to test by definition), I think it's not worth the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants