Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline styles from BlueGenes #316

Open
yochannah opened this issue Jan 2, 2019 · 2 comments · May be fixed by #456
Open

Remove inline styles from BlueGenes #316

yochannah opened this issue Jan 2, 2019 · 2 comments · May be fixed by #456
Labels
help wanted Open source contributor? Feel free to pick these issues up! A bit harder than beginner/bootcamp

Comments

@yochannah
Copy link
Member

Inline styles are bad practice - they slow down browser performance, they're hard to maintain, and they're hard to override without more inline styles.

Search for :style throughout the app and remove inline styles. Replace them with styles that are built into the less files instead.

The one exception: I think the Query Builder probably might need inline styles.
@yochannah yochannah added the help wanted Open source contributor? Feel free to pick these issues up! A bit harder than beginner/bootcamp label Jan 2, 2019
@liza-pizza
Copy link

I'll work on this if you don't mind. :)

@yochannah
Copy link
Member Author

yochannah commented Dec 10, 2019 via email

@liza-pizza liza-pizza linked a pull request Dec 25, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open source contributor? Feel free to pick these issues up! A bit harder than beginner/bootcamp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove inline styles liza-pizza/bluegenes
2 participants
@yochannah @liza-pizza