From e387091392a846f126d84421439ff5b07895cf3c Mon Sep 17 00:00:00 2001 From: CodHeK Date: Sat, 9 Mar 2019 15:15:54 +0530 Subject: [PATCH 1/2] better column summary headings --- .DS_Store | Bin 0 -> 6148 bytes src/messages/summary.coffee | 2 +- templates/summary-heading.mtpl | 8 ++++---- 3 files changed, 5 insertions(+), 5 deletions(-) create mode 100644 .DS_Store diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..aca995b8d5225c22e31780d350e4e1118afed582 GIT binary patch literal 6148 zcmeHKy-EW?5S~pAi3pN1<+he-tioG6S>U-OSE@?00apOGIXHllO_bMAU&Zw$?E;80XoStmPwIYyqA+at&8b0P25*5~(L6RPqx zZ&NgjT5T!HE&Zs;$3@TUNu!f6;K6MDS)2M*4Yr$ zQ58@HRDntX{y$haW9qRKbiWP^?g{`*5O#)Vcg6!+4ggb+r63|OBc(toHU5fWq#SYU z=cOJ?K`AHWn6Zv$HvWbpCrrexn@%Pb)KL{s1!4u-^4jJ8zq|VW9~bGHDxeDdD+NrF z4YL8ZvY23_7R+zpB6& D4|{ia literal 0 HcmV?d00001 diff --git a/src/messages/summary.coffee b/src/messages/summary.coffee index 52380850..eb948ba0 100644 --- a/src/messages/summary.coffee +++ b/src/messages/summary.coffee @@ -22,7 +22,7 @@ Messages.setWithPrefix 'summary', <% } %> """ - NumericDistribution: 'Showing distribution of <%= formatNumber(n) %>' + NumericDistribution: 'Showing distribution of <%= formatNumber(n) %> distinct' FilterValuesPlaceholder: 'Filter values' DownloadData: 'Download data' DownloadFormat: 'As' diff --git a/templates/summary-heading.mtpl b/templates/summary-heading.mtpl index 2e2d2cc4..3f5ca086 100644 --- a/templates/summary-heading.mtpl +++ b/templates/summary-heading.mtpl @@ -1,19 +1,19 @@ <% /* requires: * numeric, available, got, uniqueValues * state.typeName, state.endName - * filtered + * filtered */ %>

<% if (numeric) { %> <%- Messages.getText('summary.NumericDistribution', {n: available}) %> <%- state.typeName %> <%- pluralise(state.endName, got) %> - <% } else { %> + <% } else { %> <%- Messages.getText('summary.Got', {available: available, got: got}) %> - <%- Messages.getText('Number', {n: available}) %> + <%- Messages.getText('Number', {n: available}) %> distinct <%- state.typeName %> <%- pluralise(state.endName, got) %> @@ -23,5 +23,5 @@ total: uniqueValues }) %> - <% } %> + <% } %>

From a7a871cc69d9661ade956bb1ce447746ac9e6aef Mon Sep 17 00:00:00 2001 From: CodHeK Date: Sat, 9 Mar 2019 15:30:17 +0530 Subject: [PATCH 2/2] update for numeric heading --- src/messages/summary.coffee | 2 +- templates/summary-heading.mtpl | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/messages/summary.coffee b/src/messages/summary.coffee index eb948ba0..451982f2 100644 --- a/src/messages/summary.coffee +++ b/src/messages/summary.coffee @@ -22,7 +22,7 @@ Messages.setWithPrefix 'summary', <% } %> """ - NumericDistribution: 'Showing distribution of <%= formatNumber(n) %> distinct' + NumericDistribution: '<%= formatNumber(n) %> distinct' FilterValuesPlaceholder: 'Filter values' DownloadData: 'Download data' DownloadFormat: 'As' diff --git a/templates/summary-heading.mtpl b/templates/summary-heading.mtpl index 3f5ca086..7db62cbf 100644 --- a/templates/summary-heading.mtpl +++ b/templates/summary-heading.mtpl @@ -7,6 +7,10 @@ <% if (numeric) { %> <%- Messages.getText('summary.NumericDistribution', {n: available}) %> <%- state.typeName %> + <%- pluralise(state.endName, got) %> for + + <%- Messages.getText('Number', {n: available}) %> + <%- pluralise(state.endName, got) %> <% } else { %>