Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please translate inline comments #5

Open
Saphareas opened this issue Nov 23, 2019 · 2 comments
Open

Please translate inline comments #5

Saphareas opened this issue Nov 23, 2019 · 2 comments

Comments

@Saphareas
Copy link

Hi, first of all thank you! I've been looking for such a library for over a year.
Could you please translate the inline comments to English? I would like to add support for the PCR800 rain sensor (0x2914), but first I need to be able to understand your code.

@invandy
Copy link
Owner

invandy commented Dec 9, 2019

Hello!
Thank you for you interest and sorry for long delay in reply.
I plan to translate all comments to English but with my English skill it may require a lot of time :). However if PRC800 packet length, CRC and checksum is the same like other v3 sensors, there is no need to understainding all my code. You just need to add handler of this sensor in check_CRC() and capture() functions. By the way I also have in my "todos" the adding support of PRC800.
If you need any explanation of code - let me know what part of comments is to be transleted in the first place
Regards.
Sergey.

@Saphareas
Copy link
Author

Ok, could you at least recommit Oregon_NR.cpp with correct encoding? Because the cyrillic characters are f*ed up.

By the way: Merry Christmas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants