-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth login support in the App #422
Comments
This seems to be a separate issue, for the server code, not the app - please create a separate issue on the other repository for this. Regarding oauth support on the app, it's a great idea, and I'm sure there's a way to support it. Do you have any familiarity with the flutter ecosystem, in particular with regard to oauth support? |
What about just opening a popup in which the website loads and then waits for the redirect with the token? |
from within the app? How would this work? |
Yes, I will create another one there
Im currently getting myself familiar with the flutter ecosystem so that I can start working on it. The only issue I see now is that currently logging in to Inventree in the app is tied to adding a server. So how about we separate the two things and make logging in have a separate view from adding a server? |
I like this idea, it would allow us to also look at implementing #351 In that case, we store the token rather than the username and password. If the app does not have a token, or the server responds with a "needs auth" message, we redirect to the login screen. |
Currently when signing up and creating and account using OAuth (eg. with google) I can login through the web UI just fine. But when I want to login to my account through the app I can't because it's only possible through the regular username and password.
Now what makes this even more frustrating is that when im trying to set up a password through the Settings page in the web UI, I have 3 fields:
Enter password
,Confirm password
, andOld password
. The problem withOld password
is that if I initially signed up using OAuth then I don't have a password so now I basically can't change password, rendering it impossible to connect to my account through the App if I don't have admin access to change it from the admin dashboard.I know that's another issue so i can probably open up another issue in the main repo for a fix for: When setting up the password for the first time, the input for
Old password
should not exist.Upvote & Fund
The text was updated successfully, but these errors were encountered: