Upgrade LinkTap to 0.3.0

[Smart-Gang]

Support for new device types and ioBroker dependency (admin) update

[mcm1957]

2.0.3 created 9.9.2023

[mcm1957]

just a feedback for next releases:

Added support for new devices sounds like new functionality. Thus increasing the minor version would have been correct.

The rules for versioning are:

• increase major if Breaking changes are introduced. This may include new features and bugfixes.
• increase minor if a new feature was added without breaking things. This may include bugfixes.
• increase patch if only a bug was fixed without adding new functionality.

[mcm1957]

@Smart-Gang

Your adapter https://github.com/Smart-Gang/ioBroker.linktap does not use standard iobroker testing.

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in Forum from apollon77 (Just take from other adapters the samples)

You may copy the test-and-release.yml workflow from the example adaptzer or newly created adapter. If you need help, please let uas know.

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review

[mcm1957]

I've created a PR to aid in updateing / adding standard tests. (Smart-Gang/ioBroker.linktap#10)
Please merge and check that tests pass.

After merging and checking, please drop a comment to let us continue release management.

NOTE: If there is no reaction within 14 days I will close this PR.

[Smart-Gang]

Integrated Adapter basic tests using Github Actions
Applied new minor version due to compatibility for new devices.

[mcm1957]

Thanks for your work.
Github test feedback still shows a failure. This is not caused by the standard github tests - they are ok - but by appvayour integration:

If you do not use appveyor I suggest to remove it from your test configuration. I was told that this canbe achived by

• open settings poage of github repository
• go to webhooks
• remove appveyor webhook

Of course its ok to fix the appveyor setup and to use it if you prefer. I'm sorry but I cannot aid with this testing environment. The goal should be to get a green checkmark as all tests pass.

mcm1957

P.S: appveyor issue is NOT blocking as I can check which tests fail manually - but it should be fixed in future to give you a quick feedback for durtehr work at the adapter. THANK YOU once again for your effort.

[mcm1957]

0.3.0 created 18.10.2023
manual adapter check OK

wait for minimum time at latest

[Smart-Gang]

Thanks for your work. Github test feedback still shows a failure. This is not caused by the standard github tests - they are ok - but by appvayour integration:

If you do not use appveyor I suggest to remove it from your test configuration. I was told that this canbe achived by

• open settings poage of github repository
• go to webhooks
• remove appveyor webhook

Of course its ok to fix the appveyor setup and to use it if you prefer. I'm sorry but I cannot aid with this testing environment. The goal should be to get a green checkmark as all tests pass.

mcm1957

P.S: appveyor issue is NOT blocking as I can check which tests fail manually - but it should be fixed in future to give you a quick feedback for durtehr work at the adapter. THANK YOU once again for your effort.

Thanks for the info, I stopped using the appveyor and have now removed the webhook as well.

Now all tests should be green.

Thanks for the support.

[mcm1957]

0.3.0 created 18.10.2023
18 user
OK