Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plenticore to 2.3.1 #2657

Closed
wants to merge 1 commit into from
Closed

Conversation

pixcept
Copy link

@pixcept pixcept commented Sep 19, 2023

Please update my adapter ioBroker.plenticore to version 2.3.1.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Sep 19, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.plenticore

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 19, 2023

2.3.1 created 18.09.2023

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review STABLE - brand new labels Sep 19, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Sep 19, 2023

@pixcept

Your adapter https://github.com/pixcept/ioBroker.plenticore does not use standard iobroker testing.

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in Forum from apollon77 (Just take from other adapters the samples)

You may copy the test-and-release.yml workflow from the example adapter or some newly created adapter. If you need help, please let us know.

In addition please verify that you adapter is working with js-controller 5. (See issue pixcept/ioBroker.plenticore#84)

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review

@mcm1957 mcm1957 added ON HOLD PR is set ON HOLD due to pending question or major issues. and removed STABLE - brand new labels Sep 25, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 17, 2023

As pixcept/ioBroker.plenticore#84 is still unresolved / work-in-progress I will close this PR for now.
Please ensure that the adapter is working with js-controller 5 and that basic testing is active and results in a green checkmark.
Functional testing is a requirement for updating stable revision and for keeping the adapter listed at ioBroker repositories.

If you need help fixing test issue please let us / me know.

@mcm1957 mcm1957 added cancellation of PR suggested The adapter needs significant rework before a review seems to be appropiate and removed ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 17, 2023
@mcm1957 mcm1957 closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias cancellation of PR suggested The adapter needs significant rework before a review seems to be appropiate must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants