Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add homekittiles to latest #2752

Closed
wants to merge 1 commit into from
Closed

add homekittiles to latest #2752

wants to merge 1 commit into from

Conversation

Standarduser
Copy link
Contributor

No description provided.

@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Oct 13, 2023
@github-actions github-actions bot deleted a comment from Standarduser Oct 13, 2023
@github-actions github-actions bot deleted a comment from Standarduser Oct 13, 2023
@mcm1957 mcm1957 added the RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. label Oct 13, 2023
@mcm1957 mcm1957 changed the title added homekittiles to latest add homekittiles to latest Oct 13, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.homekittiles

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W164] Adapters without config "common.noConfig = true" should also set "common.adminUI.config = none"
  • 👀 [W400] Cannot find "homekittiles" in latest repository

Add comment "RE-CHECK!" to start check anew

@Apollon77
Copy link
Collaborator

Please rename to haveve "vis-" in front of the name as with all other widgets. This is important for the users to understand that this is not a standalone adapter but a vis "addon". thank you

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 13, 2023

As this is a pure VIS adapter provising widgets, this adapter should / must be named

vis-xxx (i.e. vis-homekittiles)

See sources-dist.json and scan for type 'visualization-widgets'

Please rename your adapter.

If you have any further questions related to the naming scheme please contact @Apollon77.

As renaming the adapter makes this PR obsolete, I will close here. Please create a new PR as soon as you have finished renaming process.

In addition please:

  • convert README:md to plain english. Its Ok to have additional descriptions in other, languages (typically located at doc directory) and its OK to link to them in README.md but main README.md must be in english.

@mcm1957 mcm1957 closed this Oct 13, 2023
@mcm1957 mcm1957 added invalid and removed RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias invalid must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants