Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tado to 0.4.11 #2754

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Bump Tado to 0.4.11 #2754

merged 1 commit into from
Oct 15, 2023

Conversation

HGlab01
Copy link
Contributor

@HGlab01 HGlab01 commented Oct 13, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 13, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.tado

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W202] Version of package.json (0.4.12-alpha.0) doesn't match latest version on NPM (0.4.11)

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 13, 2023

0.4.11 created 09.10.2023
72 user
OK

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 13, 2023

@HGlab01
Please fix ad least sentry issue:

  • This adapter seems to use sentry, but no sentry info is added to Readme.md

    This adapter seems to use sentry for error logging. Please add the suggested sentry information at the top of Readme.md

    **This adapter uses Sentry libraries to automatically report exceptions and code errors to the developers.** For more details and for information how to disable the error reporting see [Sentry-Plugin Documentation](https://github.com/ioBroker/plugin-sentry#plugin-sentry)! Sentry reporting is used starting with js-controller 3.0.

  • Readme.md should contain a link to the manufacturer and/or device (non blocking but could be solved at once)

    The README.md of any adapter related to device or m ultiple devices of a manufacturer should contain a link the manufacturers website and/or to a description of the device. This is to anable new users to easily check wether they associate the adapter with the correct device(s). (See https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository paragraph 4.)

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. STABLE - brand new labels Oct 13, 2023
@HGlab01
Copy link
Contributor Author

HGlab01 commented Oct 13, 2023

@mcm1957 thanks, sentry info gots lost somewhen/somehow. Link added as well

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 13, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 15, 2023

0.4.11 created 09.10.2023
88 user
OK

@mcm1957 mcm1957 merged commit 2997b12 into ioBroker:master Oct 15, 2023
18 checks passed
@HGlab01 HGlab01 deleted the patch-3 branch October 18, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants