Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webui to 1.20.6 #3070

Closed
wants to merge 1 commit into from
Closed

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Dec 15, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 15, 2023

1.20.6 created at 12.12.2023

@mcm1957 mcm1957 added STABLE - brand new and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Dec 15, 2023
@mcm1957 mcm1957 changed the title Update sources-dist-stable.json Update swebui to 1.20.6 Dec 15, 2023
@mcm1957 mcm1957 changed the title Update swebui to 1.20.6 Update webui to 1.20.6 Dec 15, 2023
@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 15, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 15, 2023

@jogibear9988
Please ensure that 1.20.6 will be available at latest for at least 7 days so that it can be installed by latest users and tested.
This requires, that you avoid publishing new releases as this would abort the test phase and users will no longer install or keep this release active.

Creating .alpha.0 releases would be ok as those release should not be published at latest when using the standard workflow.

@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 15, 2023
@jogibear9988
Copy link
Contributor Author

For me this workflow does not work, sometimes I fix critical bugs, and after that there are still new releases. When I create a pull here it is tested enough.

@github-actions github-actions bot added the *📬 a new comment has been added label Dec 15, 2023
@mcm1957 mcm1957 closed this Dec 15, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 15, 2023

For me this workflow does not work, sometimes I fix critical bugs, and after that there are still new releases. When I create a pull here it is tested enough.

A critical bug will be provided very fast - you just need to tell:

IMPORTANT:
Of course, it is possible to release a new version immediately if it is a hotfix for a serious problem, i.e. some errors cause adapter crashes or incompatible api changes of external websites blocking normal usage. In this case, please indicate this fact as a comment and mention mcm1957 and eventually Apollon77 explicitly. Please describe the reason (i.e. by referencing an issue). Hotfixes should minimize the changes, even dependency updates should be avoided if not related to the fix. New functionality and major (breaking) updates are most likely never a hotfix.

But 1.20.6 CANNOT be a critical ptach release to 0.18.4 as the minor version encreased by 2 numbers and the code conatins much more than a singel (or multiple) critical fixes. So let it run at latest for some time to be tested.

Theres no need to produce new releases while one is beeing tested at latest. Unless you have to fix something which of course starts the test phase again.

It no problem to test new code directly at your development environmant or from npm. You only should avoid to publich it to latest unless you want to become this release the next test candidate. When using standard workflow using .alpha.x releases will avoid publishing at latest repository.

So PLEASE do NOT create a new release (except .alpha.*) until 1.20.6 has been available at latest for app 7 days and is installed and tested by users. If there'S something to fix, a 1.20.7 is OK of course - i'll update this PR in that case.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Dec 15, 2023
@mcm1957 mcm1957 reopened this Dec 15, 2023
@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 15, 2023
Copy link

Automated adapter checker

ioBroker.webui

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

Adapter releases: https://www.iobroker.dev/adapter/webui/releases

Adapter statistic: https://www.iobroker.dev/adapter/webui/statistics

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Dec 15, 2023
@github-actions github-actions bot added the ⚠️check Issue/PR needs attention label Dec 16, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 16, 2023

As 0.20.7 has been released to latest I cancel this PR.

Please create a new PR when 0.20.7 (or a leter version) has been available at LATEST for at least 7 days to be installed by users.

0.20.6 contains at least one issue which is fixed with 0.20.7 So it is obviously beeter to wait for the fixed release to be tested and to release this to stable. In addition 0.20.6 cannot be tested enough any more as you created a new release which aborts test phase.

@mcm1957 mcm1957 closed this Dec 16, 2023
@mcm1957 mcm1957 added wontfix and removed STABLE - brand new ⚠️check Issue/PR needs attention labels Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants