Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sureflap to 2.1.1 #3397

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Update sureflap to 2.1.1 #3397

merged 1 commit into from
Mar 13, 2024

Conversation

Sickboy78
Copy link
Contributor

Please update my adapter ioBroker.sureflap to version 2.1.1.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

As you are limiting the tests to node 18 and 20 (which is OK) the adapter must require node 18 minimum.

Please check and merge PR Sickboy78/ioBroker.sureflap#55 to add engines clause to package.json.

Note: a new release is not required immidiatly but note the fact that node 18 is required at README.md

reminder 15.3.2024

@mcm1957 mcm1957 added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 13, 2024

PR merged

@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Mar 13, 2024
Copy link

Automated adapter checker

ioBroker.sureflap

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

Adapter releases: https://www.iobroker.dev/adapter/sureflap/releases
Adapter statistic: https://www.iobroker.dev/adapter/sureflap/statistics

History and usage information for release 2.1.1:

2.1.1 created 25.2.2024 (16 days old)
26 users (9.59%)

1.2.3 (stable) created 29.12.2023 (74 days old)
168 users (stable) (61.99%)

Please verify that this PR really tries to update to release 2.1.1!

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot deleted a comment from mcm1957 Mar 13, 2024
@mcm1957 mcm1957 merged commit e9457f7 into ioBroker:master Mar 13, 2024
11 checks passed
@mcm1957 mcm1957 removed the 15.3.2024 label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants