Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update net-tools to 1.0.6 #3398

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Update net-tools to 1.0.6 #3398

merged 1 commit into from
Mar 13, 2024

Conversation

Jey-Cee
Copy link
Contributor

@Jey-Cee Jey-Cee commented Mar 12, 2024

Please update my adapter ioBroker.net-tools to version 1.0.6.

This pull request was created by https://www.iobroker.dev c0726ff.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

@Apollon77

As this is now a paid adapter, please confirm that it's ok to release it to stable in respect to commercial / contract aspects.

@Jey-Cee

Please fix test-and-release workflow. This workflow must pass for a release to be added to stable.

Seems that io-package.json contains commin.license AND common.licenseInformation. common.license must be removed;

  1. common.license should not exist together with common.licenseInformation

reminder 14.3.2024

@mcm1957 mcm1957 added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Mar 12, 2024
@Jey-Cee
Copy link
Contributor Author

Jey-Cee commented Mar 12, 2024

Not possible actual if you want to use developer portal for release:
ioBroker/dev-portal#75

@github-actions github-actions bot added 14.3.2024 *📬 a new comment has been added and removed 14.3.1024 labels Mar 12, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

@Jey-Cee

Not possible actual if you want to use developer portal for release: ioBroker/dev-portal#75

Please ignore the false positive from adapter checker for now. You can update the stable release manually - should not be a problem for you :-). And you already created a PR - so no problem with dev-portal for now too.

Please fix package.json so that workflow test-and release passes the tests. Passing standard github tests is mandatory for new relases to be added to stable and problem can be solved easily by editing package.json and removing the outdated license line.

@Jey-Cee
THANKS - see thats already done

@mcm1957 mcm1957 added paid This is a pid adapter, confirmation from GMBH needed and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Mar 12, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 12, 2024

Standard GH Tests OK

@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 13, 2024

OK lt. Bluefox:

@bluefox27
Frage:
Existiert für den Adapter ioBroker.net-tools, maintained by JeeCey eine kommerzielle Vereinbarung mit der GmbH die erlaubt diesen Adapter als paid adapter anzubieten?

https://t.me/c/2020938082/354
Ja. Ich habe 15% angefordert

@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Mar 13, 2024
@github-actions github-actions bot deleted a comment from mcm1957 Mar 13, 2024
Copy link

Automated adapter checker

ioBroker.net-tools

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E115] No license found in io-package.json
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)

Adapter releases: https://www.iobroker.dev/adapter/net-tools/releases
Adapter statistic: https://www.iobroker.dev/adapter/net-tools/statistics

History and usage information for release 1.0.6:

1.0.6 created 5.3.2024 (8 days old)
229 users (1.55%)

0.2.0 (stable) created 16.5.2022 (667 days old)
13579 users (stable) (91.99%)

Please verify that this PR really tries to update to release 1.0.6!

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Mar 13, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Mar 13, 2024

[E115] - false positive

@mcm1957 mcm1957 merged commit 78b87ab into ioBroker:master Mar 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias paid This is a pid adapter, confirmation from GMBH needed Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants