Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vis-2-widgets-rssfeed to latest #3785

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add vis-2-widgets-rssfeed to latest #3785

merged 2 commits into from
Jul 18, 2024

Conversation

oweitman
Copy link
Contributor

@oweitman oweitman commented Jul 1, 2024

[E124] Main file not found under URL: https://raw.githubusercontent.com/oweitman/ioBroker.vis-2-widgets-rssfeed/main/widgets/vis-2-widgets-rssfeed/customWidgets.js
-> datei wird im build prozess erzeugt

[E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.vis-2-widgets-rssfeed"
-> bluefox wurde hinzugefügt und hat angenommen

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
-> datei wird im build prozess erzeugt

[W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
-> ja genau, hier ist es

[W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
-> für vis-2 widgets wird es noch benötigt

[E124] Main file not found under URL: https://raw.githubusercontent.com/oweitman/ioBroker.vis-2-widgets-rssfeed/main/widgets/vis-2-widgets-rssfeed/customWidgets.js
-> datei wird im build prozess erzeugt

[E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.vis-2-widgets-rssfeed"
-> bluefox wurde hinzugefügt, er hat noch nicht angenommen

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
-> datei wird im build prozess erzeugt

[W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
-> ja genau, hier ist es

[W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
-> für vis-2 widgets wird es noch benötigt
@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Jul 1, 2024
@mcm1957 mcm1957 changed the title bring vis-2-widgets-rssfeed to latest Add vis-2-widgets-rssfeed to latest Jul 1, 2024
@mcm1957 mcm1957 added the RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. label Jul 1, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 1, 2024

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them.

You will find the results of the review and eventually issues / suggestings as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.

reminder 15.7.2024

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 1, 2024

[E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file can be ignored (false positive)

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 1, 2024
@github-actions github-actions bot deleted a comment from oweitman Jul 1, 2024
@oweitman
Copy link
Contributor Author

oweitman commented Jul 1, 2024

[W184] "common.noConfig" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI.config":"none".

und

[E114] No adapter are allowed in the repo without admin support (set "common.noConfig = true" and "common.adminUI.config = none" if adapter has no configuration)

ersteres ist etwas missverständlich formuliert. deprecated sieht so aus als ob man es entfernen sollte.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 4, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Jul 5, 2024
@github-actions github-actions bot deleted a comment from oweitman Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Automated adapter checker

ioBroker.vis-2-widgets-rssfeed

Downloads - Test and Release
NPM

  • ❗ [E519] "widgets/vis-2-widgets-rssfeed/customWidgets.js" found in package.json, but not found as file
  • 👀 [W184] "common.noConfig" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI.config":"none".
  • 👀 [W400] Cannot find "vis-2-widgets-rssfeed" in latest repository
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 5, 2024
@ioBroker ioBroker deleted a comment from oweitman Jul 14, 2024
@github-actions github-actions bot added the *📬 a new comment has been added label Jul 14, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 14, 2024
@mcm1957 mcm1957 merged commit 39a9afb into ioBroker:master Jul 18, 2024
12 checks passed
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 18, 2024

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

  • errors reported by adapter checker

    Errors for now. Chcker has to be improved.

Thanks for reading and evaluating this suggestions.
McM1957

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 18, 2024

This adapter has been released to latest repository and should be visible within 24h maximum.

@mcm1957 mcm1957 added lgtm Looks Good To Me and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review RE-REVIEW pending (by mcm1957) Changes requested by review have been applied, re-review could be done. 15.7.2024 labels Jul 18, 2024
@oweitman
Copy link
Contributor Author

Danke

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*📬 a new comment has been added auto-checked This PR was automatically checked for obvious criterias lgtm Looks Good To Me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants