Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js-controller to 6.0.9 and javascript to 8.7.6 #3840

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented Jul 22, 2024

Just a prep PR we should wait around a week up from here.

@Apollon77
Copy link
Collaborator

How we make suer that javascript 8.7.1 is there too if needed for custom packages?

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 22, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 22, 2024
@foxriver76
Copy link
Collaborator Author

How we make suer that javascript 8.7.1 is there too if needed for custom packages?

from TG:

8.7.1 because of the issue with typescript types yes, so far we have always said with controller update please do all other updates before. otherwise it just does the same as before... with versions that can't do it yet and with the intermediate versions everything works except typescript types...

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 22, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Jul 22, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 22, 2024

note: ioBroker/ioBroker.javascript#1645

@foxriver76 foxriver76 marked this pull request as ready for review July 31, 2024 06:46
@foxriver76
Copy link
Collaborator Author

ready to merge from my side @Apollon77 @mcm1957

@github-actions github-actions bot added the *📬 a new comment has been added label Jul 31, 2024
@Apollon77
Copy link
Collaborator

kk, please do not forget the tag npm updates

@foxriver76
Copy link
Collaborator Author

kk, please do not forget the tag npm updates

Isn’t this now done by CI? @mcm1957

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 31, 2024

kk, please do not forget the tag npm updates

Isn’t this now done by CI? @mcm1957

Yes should be done by a workflow

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 31, 2024

I do not see any reason to wait longer except that maybe we could wait one more day so that new js-controller gets available at 2.8. As on 1.8. Dependabot will send some mails and therevis a small Chance to not see urgent notifications at Mailbox at 1.x of month.

@mcm1957
Copy link
Collaborator

mcm1957 commented Jul 31, 2024

Please let me know if I should release today or tomorrow or feel free to merge yourself

@foxriver76 foxriver76 merged commit efe8953 into master Aug 1, 2024
6 checks passed
@foxriver76 foxriver76 deleted the foxriver76-patch-1 branch August 1, 2024 10:02
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Aug 1, 2024
@mcm1957 mcm1957 changed the title Prepare controller stable 6.0.9 Update js-controller to 6.0.9 and javascript to Aug 2, 2024
@mcm1957 mcm1957 changed the title Update js-controller to 6.0.9 and javascript to Update js-controller to 6.0.9 and javascript to 8.7.6 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants