-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paperless-ngx to latest #3922
base: master
Are you sure you want to change the base?
Conversation
RE-CHECK! |
Thanks for spending your time and providing a new adapter for ioBroker. Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases. In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. You will find the results of the review and eventually issues / suggestings as a comment to this PR. So please keep this PR watched. If you have any urgent questions feel free to ask. reminder 17.8.2024 |
First of all - THANK YOU for the time and effort you spend to maintain this adapter. I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.
I'm not sure where the ids of the directory structure are coming from. Please ensure, that no illegal characters are possible there (i.e. german Umlaute etc.)
Thanks for reading and evaluating this suggestions. Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review! |
reminder 15.9.2024 |
Do you need an help? reminder 28.9.2024 |
Do you need an help? reminder 15.10.2024 |
Review done at 2.11.2024
I'm not sure where the ids of the directory structure are coming from. Please ensure, that no illegal characters are possible there (i.e. german Umlaute etc.) I still do not see any filtering of illegal characters. As elementName and startDirectory are no constants fixed within soure, the must be filter. The same applies to other external data used to create ids. Please advice whre this processing is done if it is already implemented.
In general I do not see much improvments til Sommer. Please let me know if you do not have time / interest to fix the open issues within the next time. If you need any help, please let us know. Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review! |
reminder 16.11.2024 |
Ich habe die Spezifakationen und die Readme ergänzt und eine neue Version erzeugt: (1.0.4) |
@ioBroker-Bot recreate |
Automated adapter checkerioBroker.paperless-ngx👍 No errors found
Add comment "RE-CHECK!" to start check anew |
RE-REVIEW WORKSHEET ONLY _ please ignore for now
I'm not sure where the ids of the directory structure are coming from. Please ensure, that no illegal characters are possible there (i.e. german Umlaute etc.) I still do not see any filtering of illegal characters. As elementName and startDirectory are no constants fixed within soure, the must be filter. The same applies to other external data used to create ids. Please advice whre this processing is done if it is already implemented.
|
The following issues reported at last review (2.11.2024) are still open / not clearified. Please fix or indicate how they are solved anyway:
I'm not sure where the ids of the directory structure are coming from. Please ensure, that no illegal characters are possible there (i.e. german Umlaute etc.) I still do not see any filtering of illegal characters. As elementName and startDirectory are no constants fixed within soure, the must be filter. The same applies to other external data used to create ids. Please advice where this processing is done if it is already implemented.
Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review! reminder 31.12.2024 |
i think i solved the issues. |
reminder 27.12.2024 |
Please add my adapter ioBroker.paperless-ngx to latest.
This pull request was created by https://www.iobroker.dev c0726ff.